moebiusband/NuSiF-Solver
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

EnhancedSolver port complete #3

Merged
moebiusband merged 3 commits from :main into main 2024-09-19 10:47:47 +02:00
Conversation 1 Commits 3 Files Changed 200 +15972 -366
AdityaUjeniya commented 2024-07-27 02:21:36 +02:00
Contributor
Copy Link

Hello Dr. Eitzinger,
This pull request includes segregated Basic and Enhanced Solver. These versions are fully tested end-to-end and works in all generic cases.
Extensive regression and smoke testing is done with every configuration possible ( v1, v2, v3 with mg, rb, sor, also the ENABLE_MPI flag in mpi versions).
EnhancedSolver is built on top of BasicSolver, so the changes in BasicSolver reflects in EnhancedSolver.

Hello Dr. Eitzinger, This pull request includes segregated Basic and Enhanced Solver. These versions are fully tested end-to-end and works in all generic cases. Extensive regression and smoke testing is done with every configuration possible ( v1, v2, v3 with mg, rb, sor, also the ENABLE_MPI flag in mpi versions). EnhancedSolver is built on top of BasicSolver, so the changes in BasicSolver reflects in EnhancedSolver.
AdityaUjeniya added 1 commit 2024-07-27 02:21:37 +02:00
AdityaUjeniya requested review from moebiusband 2024-07-27 02:25:45 +02:00
moebiusband added 1 commit 2024-09-10 10:54:32 +02:00
moebiusband requested changes 2024-09-10 11:58:54 +02:00
moebiusband left a comment
Owner
Copy Link

Great work! Thank you.

I added some comments.
I suggest to move the residual output from progress to either main.c or a dedicated file. Maybe utils?

Otherwise it is minor things. Maybe we should switch from ICC to ICX as default. ICC is deprecated. But this is not urgent and we can also do it after the merge.

Great work! Thank you. I added some comments. I suggest to move the residual output from progress to either main.c or a dedicated file. Maybe utils? Otherwise it is minor things. Maybe we should switch from ICC to ICX as default. ICC is deprecated. But this is not urgent and we can also do it after the merge.
BasicSolver/2D-mpi/src/comm-v1.c Outdated
@ -15,3 +15,3 @@
int sum = 0;
for (int i = 0; i < position; i++) {
for (int i = 0; i < position; i += position) {
moebiusband commented 2024-09-10 10:19:26 +02:00
Owner
Copy Link

Is this correct? If yes, why is it a loop? It is always executed only one time?

Is this correct? If yes, why is it a loop? It is always executed only one time?
AdityaUjeniya commented 2024-09-16 13:52:31 +02:00
Author
Contributor
Copy Link

You were right, this function is not required in comm-v1.c in anymore. Removed.

You were right, this function is not required in comm-v1.c in anymore. Removed.
BasicSolver/2D-mpi/src/comm-v3.c
@ -268,2 +267,4 @@
#endif
}
void commUpdateDatatypes(Comm* oldcomm, Comm* newcomm, int imaxLocal, int jmaxLocal)
moebiusband commented 2024-09-10 10:42:44 +02:00
Owner
Copy Link

I saw this is used in the multigrid solver. Could you add a short comment here what this routine is used for.

I saw this is used in the multigrid solver. Could you add a short comment here what this routine is used for.
BasicSolver/2D-mpi/src/progress.c Outdated
@ -50,2 +50,4 @@
fflush(stdout);
}
FILE* initResidualWriter()
moebiusband commented 2024-09-10 10:51:34 +02:00
Owner
Copy Link

I would not put it here, but in the main.c file. The general output is also in main and it is not a lot of code.

I would not put it here, but in the main.c file. The general output is also in main and it is not a lot of code.
BasicSolver/2D-mpi/src/progress.h Outdated
@ -11,3 +11,3 @@
extern void printProgress(double);
extern void stopProgress();
extern FILE* initResidualWriter(void);
moebiusband commented 2024-09-10 10:51:51 +02:00
Owner
Copy Link

See above, put in main.c

See above, put in main.c
BasicSolver/2D-seq/config.mk
@ -1,12 +1,12 @@
# Supported: GCC, CLANG, ICC
TAG ?= CLANG
TAG ?= ICC
moebiusband commented 2024-09-10 10:56:14 +02:00
Owner
Copy Link

Maybe we should consider switching to ICX as ICC is deprecated

Maybe we should consider switching to ICX as ICC is deprecated
AdityaUjeniya commented 2024-09-16 13:58:10 +02:00
Author
Contributor
Copy Link

Done

Done
BasicSolver/2D-seq/src/progress.c
@ -50,2 +50,4 @@
fflush(stdout);
}
FILE* initResidualWriter()
moebiusband commented 2024-09-10 10:57:51 +02:00
Owner
Copy Link

As mentioned before. Put in main.c

As mentioned before. Put in main.c
BasicSolver/2D-seq/src/progress.h
@ -10,5 +10,7 @@
extern void initProgress(double);
extern void printProgress(double);
extern void stopProgress(void);
extern FILE* initResidualWriter(void);
moebiusband commented 2024-09-10 10:58:07 +02:00
Owner
Copy Link

Put in main.c

Put in main.c
BasicSolver/3D-mpi/src/progress.c
@ -48,3 +48,18 @@ void stopProgress()
printf("\n");
fflush(stdout);
}
moebiusband commented 2024-09-10 11:06:53 +02:00
Owner
Copy Link

Please move everywhere to main.c or maybe put in separate compilation unit

Please move everywhere to main.c or maybe put in separate compilation unit
AdityaUjeniya added 1 commit 2024-09-16 13:51:31 +02:00
AdityaUjeniya commented 2024-09-16 13:53:43 +02:00
Author
Contributor
Copy Link

The requested changes has been done.

  1. Moved the residualWriter methods to main.
  2. Changed and tested with ICX.
  3. Removed sum() function from comm-v1.c
  4. Annotated the need for commUpdateDatatypes in MG.
The requested changes has been done. 1. Moved the residualWriter methods to main. 2. Changed and tested with ICX. 3. Removed sum() function from comm-v1.c 4. Annotated the need for commUpdateDatatypes in MG.
moebiusband merged commit d6aa1cf113 into main 2024-09-19 10:47:47 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
moebiusband
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: moebiusband/NuSiF-Solver#3
No description provided.
Delete Branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?