mirror of
https://github.com/ClusterCockpit/cc-backend
synced 2025-11-26 03:23:07 +01:00
Fix security issues Remove redundant code Add documentation Add units tests
173 lines
5.2 KiB
Go
173 lines
5.2 KiB
Go
// Copyright (C) NHR@FAU, University Erlangen-Nuremberg.
|
|
// All rights reserved. This file is part of cc-backend.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package auth
|
|
|
|
import (
|
|
"crypto/ed25519"
|
|
"encoding/base64"
|
|
"errors"
|
|
"net/http"
|
|
"os"
|
|
|
|
cclog "github.com/ClusterCockpit/cc-lib/ccLogger"
|
|
"github.com/ClusterCockpit/cc-lib/schema"
|
|
"github.com/golang-jwt/jwt/v5"
|
|
)
|
|
|
|
type JWTCookieSessionAuthenticator struct {
|
|
publicKey ed25519.PublicKey
|
|
privateKey ed25519.PrivateKey
|
|
publicKeyCrossLogin ed25519.PublicKey // For accepting externally generated JWTs
|
|
}
|
|
|
|
var _ Authenticator = (*JWTCookieSessionAuthenticator)(nil)
|
|
|
|
func (ja *JWTCookieSessionAuthenticator) Init() error {
|
|
pubKey, privKey := os.Getenv("JWT_PUBLIC_KEY"), os.Getenv("JWT_PRIVATE_KEY")
|
|
if pubKey == "" || privKey == "" {
|
|
cclog.Warn("environment variables 'JWT_PUBLIC_KEY' or 'JWT_PRIVATE_KEY' not set (token based authentication will not work)")
|
|
return errors.New("environment variables 'JWT_PUBLIC_KEY' or 'JWT_PRIVATE_KEY' not set (token based authentication will not work)")
|
|
} else {
|
|
bytes, err := base64.StdEncoding.DecodeString(pubKey)
|
|
if err != nil {
|
|
cclog.Warn("Could not decode JWT public key")
|
|
return err
|
|
}
|
|
ja.publicKey = ed25519.PublicKey(bytes)
|
|
bytes, err = base64.StdEncoding.DecodeString(privKey)
|
|
if err != nil {
|
|
cclog.Warn("Could not decode JWT private key")
|
|
return err
|
|
}
|
|
ja.privateKey = ed25519.PrivateKey(bytes)
|
|
}
|
|
|
|
// Look for external public keys
|
|
pubKeyCrossLogin, keyFound := os.LookupEnv("CROSS_LOGIN_JWT_PUBLIC_KEY")
|
|
if keyFound && pubKeyCrossLogin != "" {
|
|
bytes, err := base64.StdEncoding.DecodeString(pubKeyCrossLogin)
|
|
if err != nil {
|
|
cclog.Warn("Could not decode cross login JWT public key")
|
|
return err
|
|
}
|
|
ja.publicKeyCrossLogin = ed25519.PublicKey(bytes)
|
|
} else {
|
|
ja.publicKeyCrossLogin = nil
|
|
cclog.Debug("environment variable 'CROSS_LOGIN_JWT_PUBLIC_KEY' not set (cross login token based authentication will not work)")
|
|
return errors.New("environment variable 'CROSS_LOGIN_JWT_PUBLIC_KEY' not set (cross login token based authentication will not work)")
|
|
}
|
|
|
|
// Warn if other necessary settings are not configured
|
|
if Keys.JwtConfig != nil {
|
|
if Keys.JwtConfig.CookieName == "" {
|
|
cclog.Info("cookieName for JWTs not configured (cross login via JWT cookie will fail)")
|
|
return errors.New("cookieName for JWTs not configured (cross login via JWT cookie will fail)")
|
|
}
|
|
if !Keys.JwtConfig.ValidateUser {
|
|
cclog.Info("forceJWTValidationViaDatabase not set to true: CC will accept users and roles defined in JWTs regardless of its own database!")
|
|
}
|
|
if Keys.JwtConfig.TrustedIssuer == "" {
|
|
cclog.Info("trustedExternalIssuer for JWTs not configured (cross login via JWT cookie will fail)")
|
|
return errors.New("trustedExternalIssuer for JWTs not configured (cross login via JWT cookie will fail)")
|
|
}
|
|
} else {
|
|
cclog.Warn("config for JWTs not configured (cross login via JWT cookie will fail)")
|
|
return errors.New("config for JWTs not configured (cross login via JWT cookie will fail)")
|
|
}
|
|
|
|
cclog.Info("JWT Cookie Session authenticator successfully registered")
|
|
return nil
|
|
}
|
|
|
|
func (ja *JWTCookieSessionAuthenticator) CanLogin(
|
|
user *schema.User,
|
|
username string,
|
|
rw http.ResponseWriter,
|
|
r *http.Request,
|
|
) (*schema.User, bool) {
|
|
jc := Keys.JwtConfig
|
|
cookieName := ""
|
|
if jc.CookieName != "" {
|
|
cookieName = jc.CookieName
|
|
}
|
|
|
|
// Try to read the JWT cookie
|
|
if cookieName != "" {
|
|
jwtCookie, err := r.Cookie(cookieName)
|
|
|
|
if err == nil && jwtCookie.Value != "" {
|
|
return user, true
|
|
}
|
|
}
|
|
|
|
return nil, false
|
|
}
|
|
|
|
func (ja *JWTCookieSessionAuthenticator) Login(
|
|
user *schema.User,
|
|
rw http.ResponseWriter,
|
|
r *http.Request,
|
|
) (*schema.User, error) {
|
|
jc := Keys.JwtConfig
|
|
jwtCookie, err := r.Cookie(jc.CookieName)
|
|
var rawtoken string
|
|
|
|
if err == nil && jwtCookie.Value != "" {
|
|
rawtoken = jwtCookie.Value
|
|
}
|
|
|
|
token, err := jwt.Parse(rawtoken, func(t *jwt.Token) (any, error) {
|
|
if t.Method != jwt.SigningMethodEdDSA {
|
|
return nil, errors.New("only Ed25519/EdDSA supported")
|
|
}
|
|
|
|
unvalidatedIssuer, success := t.Claims.(jwt.MapClaims)["iss"].(string)
|
|
if success && unvalidatedIssuer == jc.TrustedIssuer {
|
|
// The (unvalidated) issuer seems to be the expected one,
|
|
// use public cross login key from config
|
|
return ja.publicKeyCrossLogin, nil
|
|
}
|
|
|
|
// No cross login key configured or issuer not expected
|
|
// Try own key
|
|
return ja.publicKey, nil
|
|
})
|
|
if err != nil {
|
|
cclog.Warn("JWT cookie session: error while parsing token")
|
|
return nil, err
|
|
}
|
|
|
|
if !token.Valid {
|
|
cclog.Warn("jwt token claims are not valid")
|
|
return nil, errors.New("jwt token claims are not valid")
|
|
}
|
|
|
|
claims := token.Claims.(jwt.MapClaims)
|
|
|
|
// Use shared helper to get user from JWT claims
|
|
user, err = getUserFromJWT(claims, jc.ValidateUser, schema.AuthSession, schema.AuthViaToken)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Sync or update user if configured
|
|
if !jc.ValidateUser && (jc.SyncUserOnLogin || jc.UpdateUserOnLogin) {
|
|
handleTokenUser(user)
|
|
}
|
|
|
|
// (Ask browser to) Delete JWT cookie
|
|
deletedCookie := &http.Cookie{
|
|
Name: jc.CookieName,
|
|
Value: "",
|
|
Path: "/",
|
|
MaxAge: -1,
|
|
HttpOnly: true,
|
|
}
|
|
http.SetCookie(rw, deletedCookie)
|
|
|
|
return user, nil
|
|
}
|