diff --git a/lammps/main-stub.c b/lammps/main-stub.c index 791c3ef..a6973f3 100644 --- a/lammps/main-stub.c +++ b/lammps/main-stub.c @@ -17,9 +17,6 @@ #define HLINE "----------------------------------------------------------------------------\n" -#define LATTICE_DISTANCE 10.0 -#define NEIGH_DISTANCE 1.0 - extern double computeForceLJFullNeigh_plain_c(Parameter*, Atom*, Neighbor*, Stats*); extern double computeForceLJFullNeigh_simd(Parameter*, Atom*, Neighbor*, Stats*); extern double computeForceLJHalfNeigh(Parameter*, Atom*, Neighbor*, Stats*); @@ -33,17 +30,23 @@ extern double computeForceEam(Eam*, Parameter*, Atom*, Neighbor*, Stats*); # define computeForceLJFullNeigh computeForceLJFullNeigh_plain_c #endif +// Patterns +#define P_SEQ 0 +#define P_FIX 1 +#define P_RAND 2 + void init(Parameter *param) { param->input_file = NULL; + param->force_field = FF_LJ; param->epsilon = 1.0; param->sigma6 = 1.0; param->rho = 0.8442; param->ntypes = 4; param->ntimes = 200; - param->nx = 4; - param->ny = 4; - param->nz = 2; - param->lattice = LATTICE_DISTANCE; + param->nx = 1; + param->ny = 1; + param->nz = 1; + param->lattice = 1.0; param->cutforce = 5.0; param->cutneigh = param->cutforce; param->mass = 1.0; @@ -62,13 +65,50 @@ void init(Parameter *param) { // Do not show debug messages //#define DEBUG(msg) -#define ADD_ATOM(x, y, z, vx, vy, vz) atom_x(atom->Nlocal) = base_x + x * NEIGH_DISTANCE; \ - atom_y(atom->Nlocal) = base_y + y * NEIGH_DISTANCE; \ - atom_z(atom->Nlocal) = base_z + z * NEIGH_DISTANCE; \ - atom->vx[atom->Nlocal] = vy; \ - atom->vy[atom->Nlocal] = vy; \ - atom->vz[atom->Nlocal] = vz; \ - atom->Nlocal++ + +void createNeighbors(Atom *atom, Neighbor *neighbor, int pattern, int nneighs, int nreps) { + const int maxneighs = nneighs * nreps; + neighbor->numneigh = (int*) malloc(atom->Nmax * sizeof(int)); + neighbor->neighbors = (int*) malloc(atom->Nmax * maxneighs * sizeof(int)); + + if(pattern == P_RAND && atom->Nlocal <= nneighs) { + fprintf(stderr, "Error: When using random pattern, number of atoms should be higher than number of neighbors per atom!\n"); + exit(-1); + } + + for(int i = 0; i < atom->Nlocal; i++) { + int *neighptr = &(neighbor->neighbors[i * neighbor->maxneighs]); + int j = (pattern == P_SEQ) ? (i + 1) : 0; + int m = (pattern == P_SEQ) ? atom->Nlocal : nneighs; + + for(int k = 0; k < nneighs; k++) { + if(pattern == P_RAND) { + int found = 0; + do { + j = rand() % atom->Nlocal; + neighptr[k] = j; + found = (int)(i == j); + for(int l = 0; l < k; l++) { + if(neighptr[l] == j) { + found = 1; + } + } + } while(found == 1); + } else { + neighptr[k] = j; + j = (j + 1) % m; + } + } + + for(int r = 1; r < nreps; r++) { + for(int k = 0; k < nneighs; k++) { + neighptr[r * nneighs + k] = neighptr[k]; + } + } + + neighbor->numneigh[i] = nneighs * nreps; + } +} int main(int argc, const char *argv[]) { Eam eam; @@ -77,7 +117,11 @@ int main(int argc, const char *argv[]) { Neighbor neighbor; Stats stats; Parameter param; - int atoms_per_unit_cell = 8; + char *pattern_str = NULL; + int pattern = P_SEQ; + int natoms = 256; + int nneighs = 76; + int nreps = 1; int csv = 0; LIKWID_MARKER_INIT; @@ -85,64 +129,62 @@ int main(int argc, const char *argv[]) { DEBUG("Initializing parameters...\n"); init(¶m); - for(int i = 0; i < argc; i++) - { - if((strcmp(argv[i], "-f") == 0)) - { + for(int i = 0; i < argc; i++) { + if((strcmp(argv[i], "-f") == 0)) { if((param.force_field = str2ff(argv[++i])) < 0) { fprintf(stderr, "Invalid force field!\n"); exit(-1); } continue; } - if((strcmp(argv[i], "-e") == 0)) - { + if((strcmp(argv[i], "-p") == 0)) { + pattern_str = strdup(argv[++i]); + if(strncmp(pattern_str, "seq", 3) == 0) { pattern = P_SEQ; } + else if(strncmp(pattern_str, "fix", 3) == 0) { pattern = P_FIX; } + else if(strncmp(pattern_str, "rand", 3) == 0) { pattern = P_RAND; } + else { + fprintf(stderr, "Invalid pattern!\n"); + exit(-1); + } + continue; + } + if((strcmp(argv[i], "-e") == 0)) { param.eam_file = strdup(argv[++i]); continue; } - if((strcmp(argv[i], "-n") == 0) || (strcmp(argv[i], "--nsteps") == 0)) - { + if((strcmp(argv[i], "-n") == 0) || (strcmp(argv[i], "--nsteps") == 0)) { param.ntimes = atoi(argv[++i]); continue; } - if((strcmp(argv[i], "-nx") == 0)) - { - param.nx = atoi(argv[++i]); + if((strcmp(argv[i], "-na") == 0)) { + natoms = atoi(argv[++i]); continue; } - if((strcmp(argv[i], "-ny") == 0)) - { - param.ny = atoi(argv[++i]); + if((strcmp(argv[i], "-nn") == 0)) { + nneighs = atoi(argv[++i]); continue; } - if((strcmp(argv[i], "-nz") == 0)) - { - param.nz = atoi(argv[++i]); + if((strcmp(argv[i], "-nr") == 0)) { + nreps = atoi(argv[++i]); continue; } - if((strcmp(argv[i], "-na") == 0)) - { - atoms_per_unit_cell = atoi(argv[++i]); - continue; - } - if((strcmp(argv[i], "--freq") == 0)) - { + if((strcmp(argv[i], "--freq") == 0)) { param.proc_freq = atof(argv[++i]); continue; } - if((strcmp(argv[i], "--csv") == 0)) - { + if((strcmp(argv[i], "--csv") == 0)) { csv = 1; continue; } - if((strcmp(argv[i], "-h") == 0) || (strcmp(argv[i], "--help") == 0)) - { + if((strcmp(argv[i], "-h") == 0) || (strcmp(argv[i], "--help") == 0)) { printf("MD Bench: A minimalistic re-implementation of miniMD\n"); printf(HLINE); printf("-f : force field (lj or eam), default lj\n"); - printf("-n / --nsteps : set number of timesteps for simulation\n"); - printf("-nx/-ny/-nz : set linear dimension of systembox in x/y/z direction\n"); - printf("-na : set number of atoms per unit cell\n"); + printf("-p : pattern for data accesses (seq, fix or rand)\n"); + printf("-n / --nsteps : number of timesteps for simulation\n"); + printf("-na : number of atoms (default 256)\n"); + printf("-nn : number of neighbors per atom (default 76)\n"); + printf("-nr : number of times neighbor lists should be replicated (default 1)\n"); printf("--freq : set CPU frequency (GHz) and display average cycles per atom and neighbors\n"); printf("--csv: set output as CSV style\n"); printf(HLINE); @@ -150,16 +192,15 @@ int main(int argc, const char *argv[]) { } } + if(pattern_str == NULL) { + pattern_str = strdup("seq\0"); + } if(param.force_field == FF_EAM) { DEBUG("Initializing EAM parameters...\n"); initEam(&eam, ¶m); } - param.xprd = param.nx * LATTICE_DISTANCE; - param.yprd = param.ny * LATTICE_DISTANCE; - param.zprd = param.nz * LATTICE_DISTANCE; - DEBUG("Initializing atoms...\n"); initAtom(atom); initStats(&stats); @@ -177,59 +218,31 @@ int main(int argc, const char *argv[]) { } DEBUG("Creating atoms...\n"); - for(int i = 0; i < param.nx; ++i) { - for(int j = 0; j < param.ny; ++j) { - for(int k = 0; k < param.nz; ++k) { - int added_atoms = 0; - int fac_x = 1; - int fac_y = 1; - int fac_z = 1; - int fmod = 0; - MD_FLOAT base_x = i * LATTICE_DISTANCE; - MD_FLOAT base_y = j * LATTICE_DISTANCE; - MD_FLOAT base_z = k * LATTICE_DISTANCE; - MD_FLOAT vx = 0.0; - MD_FLOAT vy = 0.0; - MD_FLOAT vz = 0.0; - - while(atom->Nlocal > atom->Nmax - atoms_per_unit_cell) { - growAtom(atom); - } - - while(fac_x * fac_y * fac_z < atoms_per_unit_cell) { - if(fmod == 0) { fac_x *= 2; } - if(fmod == 1) { fac_y *= 2; } - if(fmod == 2) { fac_z *= 2; } - fmod = (fmod + 1) % 3; - } - - MD_FLOAT offset_x = (fac_x > 1) ? 1.0 / (fac_x - 1) : (int)fac_x; - MD_FLOAT offset_y = (fac_y > 1) ? 1.0 / (fac_y - 1) : (int)fac_y; - MD_FLOAT offset_z = (fac_z > 1) ? 1.0 / (fac_z - 1) : (int)fac_z; - for(int ii = 0; ii < fac_x; ++ii) { - for(int jj = 0; jj < fac_y; ++jj) { - for(int kk = 0; kk < fac_z; ++kk) { - if(added_atoms < atoms_per_unit_cell) { - atom->type[atom->Nlocal] = rand() % atom->ntypes; - ADD_ATOM(ii * offset_x, jj * offset_y, kk * offset_z, vx, vy, vz); - added_atoms++; - } - } - } - } - } + for(int i = 0; i < natoms; ++i) { + while(atom->Nlocal > atom->Nmax - natoms) { + growAtom(atom); } + + atom->type[atom->Nlocal] = rand() % atom->ntypes; + atom_x(atom->Nlocal) = (MD_FLOAT)(i); + atom_y(atom->Nlocal) = (MD_FLOAT)(i); + atom_z(atom->Nlocal) = (MD_FLOAT)(i); + atom->vx[atom->Nlocal] = 0.0; + atom->vy[atom->Nlocal] = 0.0; + atom->vz[atom->Nlocal] = 0.0; + atom->Nlocal++; } const double estim_atom_volume = (double)(atom->Nlocal * 3 * sizeof(MD_FLOAT)); - const double estim_neighbors_volume = (double)(atom->Nlocal * (atoms_per_unit_cell - 1 + 2) * sizeof(int)); + const double estim_neighbors_volume = (double)(atom->Nlocal * (nneighs + 2) * sizeof(int)); const double estim_volume = (double)(atom->Nlocal * 6 * sizeof(MD_FLOAT) + estim_neighbors_volume); if(!csv) { + printf("Pattern: %s\n", pattern_str); printf("Number of timesteps: %d\n", param.ntimes); - printf("System size (unit cells): %dx%dx%d\n", param.nx, param.ny, param.nz); - printf("Atoms per unit cell: %d\n", atoms_per_unit_cell); - printf("Total number of atoms: %d\n", atom->Nlocal); + printf("Number of atoms: %d\n", natoms); + printf("Number of neighbors per atom: %d\n", nneighs); + printf("Number of times to replicate neighbor lists: %d\n", nreps); printf("Estimated total data volume (kB): %.4f\n", estim_volume / 1000.0); printf("Estimated atom data volume (kB): %.4f\n", estim_atom_volume / 1000.0); printf("Estimated neighborlist data volume (kB): %.4f\n", estim_neighbors_volume / 1000.0); @@ -237,20 +250,9 @@ int main(int argc, const char *argv[]) { DEBUG("Initializing neighbor lists...\n"); initNeighbor(&neighbor, ¶m); - DEBUG("Setting up neighbor lists...\n"); - setupNeighbor(¶m); - DEBUG("Building neighbor lists...\n"); - buildNeighbor(atom, &neighbor); + DEBUG("Creating neighbor lists...\n"); + createNeighbors(atom, &neighbor, pattern, nneighs, nreps); DEBUG("Computing forces...\n"); - if(param.force_field == FF_EAM) { - computeForceEam(&eam, ¶m, atom, &neighbor, &stats); - } else { - if(param.half_neigh) { - computeForceLJHalfNeigh(¶m, atom, &neighbor, &stats); - } else { - computeForceLJFullNeigh(¶m, atom, &neighbor, &stats); - } - } double T_accum = 0.0; for(int i = 0; i < param.ntimes; i++) { @@ -272,7 +274,7 @@ int main(int argc, const char *argv[]) { double freq_hz = param.proc_freq * 1.e9; const double atoms_updates_per_sec = (double)(atom->Nlocal) / T_accum * (double)(param.ntimes); const double cycles_per_atom = T_accum / (double)(atom->Nlocal) / (double)(param.ntimes) * freq_hz; - const double cycles_per_neigh = cycles_per_atom / (double)(atoms_per_unit_cell - 1); + const double cycles_per_neigh = cycles_per_atom / (double)(nneighs); if(!csv) { printf("Total time: %.4f, Mega atom updates/s: %.4f\n", T_accum, atoms_updates_per_sec / 1.e6); @@ -280,14 +282,14 @@ int main(int argc, const char *argv[]) { printf("Cycles per atom: %.4f, Cycles per neighbor: %.4f\n", cycles_per_atom, cycles_per_neigh); } } else { - printf("steps,unit cells,atoms/unit cell,total atoms,total vol.(kB),atoms vol.(kB),neigh vol.(kB),time(s),atom upds/s(M)"); + printf("steps,pattern,natoms,nneighs,nreps,total vol.(kB),atoms vol.(kB),neigh vol.(kB),time(s),atom upds/s(M)"); if(param.proc_freq > 0.0) { printf(",cy/atom,cy/neigh"); } printf("\n"); - printf("%d,%dx%dx%d,%d,%d,%.4f,%.4f,%.4f,%.4f,%.4f", - param.ntimes, param.nx, param.ny, param.nz, atoms_per_unit_cell, atom->Nlocal, + printf("%d,%s,%d,%d,%d,%.4f,%.4f,%.4f,%.4f,%.4f", + param.ntimes, pattern_str, natoms, nneighs, nreps, estim_volume / 1.e3, estim_atom_volume / 1.e3, estim_neighbors_volume / 1.e3, T_accum, atoms_updates_per_sec / 1.e6); if(param.proc_freq > 0.0) {