ClusterCockpit/cc-metric-collector
1
0
Fork 0
mirror of https://github.com/ClusterCockpit/cc-metric-collector.git synced 2025-10-21 13:25:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

correctly check for EACCESS when searching for mmpmon with exec.LookPath

Browse Source
This commit is contained in:
Roland Pabel
2025-10-17 09:11:18 +02:00
committed by Thomas Gruber
parent 09cf89a951
commit ea7c4f4ec7
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
collectors/gpfsMetric.go
View File

@@ -11,6 +11,7 @@ import (
"bufio" "bufio"
"bytes" "bytes"
"encoding/json" "encoding/json"
"errors"
"fmt" "fmt"
"io" "io"
"log" "log"
@@ -117,11 +118,11 @@ func (m *GpfsCollector) Init(config json.RawMessage) error {
// Check if mmpmon is in executable search path // Check if mmpmon is in executable search path
p, err := exec.LookPath(m.config.Mmpmon) p, err := exec.LookPath(m.config.Mmpmon)
if err != nil { if err != nil {
// if using sudo, the file must only be found, but exec.lookPath will give EPERM // if using sudo, the file must be found, but exec.lookPath will give EACCES
if m.config.Sudo && err == syscall.EPERM { if m.config.Sudo && errors.Is(err, syscall.EACCES) {
cclog.ComponentWarn(m.name, "got error looking for mmpmon binary '%s': %v . This is expected when using sudo, continuing.", m.config.Mmpmon, err) cclog.ComponentWarn(m.name, fmt.Sprintf("got error looking for mmpmon binary '%s': %v . This is expected when using sudo, continuing.", m.config.Mmpmon, err))
} else { } else {
cclog.ComponentError(m.name, "failed to find mmpmon binary '%s': %v", m.config.Mmpmon, err) cclog.ComponentError(m.name, fmt.Sprintf("failed to find mmpmon binary '%s': %v", m.config.Mmpmon, err))
return err return err
} }
} }