From d639c942d5508e57c16bcf55892b66787fb0fc31 Mon Sep 17 00:00:00 2001 From: Holger Obermaier <40787752+ho-ob@users.noreply.github.com> Date: Fri, 20 Feb 2026 14:01:51 +0100 Subject: [PATCH] Fix: Close file /proc/cpuinfo only once --- collectors/cpufreqCpuinfoMetric.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/collectors/cpufreqCpuinfoMetric.go b/collectors/cpufreqCpuinfoMetric.go index a79ca43..b302c70 100644 --- a/collectors/cpufreqCpuinfoMetric.go +++ b/collectors/cpufreqCpuinfoMetric.go @@ -86,10 +86,6 @@ func (m *CPUFreqCpuInfoCollector) Init(_ json.RawMessage) error { } } - if err := file.Close(); err != nil { - return fmt.Errorf("%s Init(): Call to file.Close() failed: %w", m.name, err) - } - // were all topology information collected? if foundFreq && len(processor) > 0 && @@ -121,6 +117,10 @@ func (m *CPUFreqCpuInfoCollector) Init(_ json.RawMessage) error { } } + if err := file.Close(); err != nil { + return fmt.Errorf("%s Init(): Call to file.Close() failed: %w", m.name, err) + } + // Check if at least one CPU with frequency information was detected if len(m.topology) == 0 { return fmt.Errorf("%s Init(): no CPU frequency info found in %s", m.name, cpuInfoFile)