Use pointer to metrics instead of forwarding full metric

collectors/collectorManager.go

@@ -37,7 +37,7 @@ var AvailableCollectors = map[string]MetricCollector{
 // Metric collector manager data structure
 type collectorManager struct {
 	collectors []MetricCollector          // List of metric collectors to use
-	output     chan lp.CCMetric           // Output channels
+	output     chan *lp.CCMetric          // Output channels
 	done       chan bool                  // channel to finish / stop metric collector manager
 	ticker     mct.MultiChanTicker        // periodically ticking once each interval
 	duration   time.Duration              // duration (for metrics that measure over a given duration)
@@ -48,7 +48,7 @@ type collectorManager struct {
 // Metric collector manager access functions
 type CollectorManager interface {
 	Init(ticker mct.MultiChanTicker, duration time.Duration, wg *sync.WaitGroup, collectConfigFile string) error
-	AddOutput(output chan lp.CCMetric)
+	AddOutput(output chan *lp.CCMetric)
 	Start()
 	Close()
 }
@@ -147,7 +147,7 @@ func (cm *collectorManager) Start() {
 }
 
 // AddOutput adds the output channel to the metric collector manager
-func (cm *collectorManager) AddOutput(output chan lp.CCMetric) {
+func (cm *collectorManager) AddOutput(output chan *lp.CCMetric) {
 	cm.output = output
 }
 

collectors/cpufreqCpuinfoMetric.go

@@ -10,8 +10,8 @@ import (
 	"strconv"
 	"strings"
 	"time"
-	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 
+	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
 //
@@ -151,8 +151,7 @@ func (m *CPUFreqCpuInfoCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-
-func (m *CPUFreqCpuInfoCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *CPUFreqCpuInfoCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -183,7 +182,7 @@ func (m *CPUFreqCpuInfoCollector) Read(interval time.Duration, output chan lp.CC
 					}
 					y, err := lp.New("cpufreq", t.tagSet, m.meta, map[string]interface{}{"value": value}, now)
 					if err == nil {
-						output <- y
+						output <- &y
 					}
 				}
 				processorCounter++

collectors/cpufreqMetric.go

@@ -183,7 +183,7 @@ func (m *CPUFreqCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *CPUFreqCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *CPUFreqCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -211,7 +211,7 @@ func (m *CPUFreqCollector) Read(interval time.Duration, output chan lp.CCMetric)
 
 		y, err := lp.New("cpufreq", t.tagSet, m.meta, map[string]interface{}{"value": cpuFreq}, now)
 		if err == nil {
-			output <- y
+			output <- &y
 		}
 	}
 }

collectors/cpustatMetric.go

@@ -7,6 +7,7 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -35,7 +36,7 @@ func (m *CpustatCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (c *CpustatCollector) parseStatLine(line string, cpu int, exclude []string, output chan lp.CCMetric) {
+func (c *CpustatCollector) parseStatLine(line string, cpu int, exclude []string, output chan *lp.CCMetric) {
 	ls := strings.Fields(line)
 	matches := []string{"", "cpu_user", "cpu_nice", "cpu_system", "cpu_idle", "cpu_iowait", "cpu_irq", "cpu_softirq", "cpu_steal", "cpu_guest", "cpu_guest_nice"}
 	for _, ex := range exclude {
@@ -54,14 +55,14 @@ func (c *CpustatCollector) parseStatLine(line string, cpu int, exclude []string,
 			if err == nil {
 				y, err := lp.New(m, tags, c.meta, map[string]interface{}{"value": int(x)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
 	}
 }
 
-func (m *CpustatCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *CpustatCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}

collectors/customCmdMetric.go

@@ -74,7 +74,7 @@ var DefaultTime = func() time.Time {
 	return time.Unix(42, 0)
 }
 
-func (m *CustomCmdCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *CustomCmdCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -99,7 +99,7 @@ func (m *CustomCmdCollector) Read(interval time.Duration, output chan lp.CCMetri
 			}
 			y, err := lp.New(c.Name(), Tags2Map(c), m.meta, Fields2Map(c), c.Time())
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 		}
 	}
@@ -121,7 +121,7 @@ func (m *CustomCmdCollector) Read(interval time.Duration, output chan lp.CCMetri
 			}
 			y, err := lp.New(f.Name(), Tags2Map(f), m.meta, Fields2Map(f), f.Time())
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 		}
 	}

collectors/diskstatMetric.go

@@ -2,7 +2,9 @@ package collectors
 
 import (
 	"io/ioutil"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
+
 	//	"log"
 	"encoding/json"
 	"errors"
@@ -72,7 +74,7 @@ func (m *DiskstatCollector) Init(config json.RawMessage) error {
 	return err
 }
 
-func (m *DiskstatCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *DiskstatCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	var lines []string
 	if !m.init {
 		return
@@ -102,7 +104,7 @@ func (m *DiskstatCollector) Read(interval time.Duration, output chan lp.CCMetric
 				if err == nil {
 					y, err := lp.New(name, tags, m.meta, map[string]interface{}{"value": int(x)}, time.Now())
 					if err == nil {
-						output <- y
+						output <- &y
 					}
 				}
 			}

collectors/gpfsMetric.go

@@ -69,7 +69,7 @@ func (m *GpfsCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *GpfsCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -157,7 +157,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 
 			y, err := lp.New("gpfs_bytes_read", m.tags, m.meta, map[string]interface{}{"value": bytesRead}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// bytes written
@@ -171,7 +171,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 
 			y, err = lp.New("gpfs_bytes_written", m.tags, m.meta, map[string]interface{}{"value": bytesWritten}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// number of opens
@@ -184,7 +184,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			}
 			y, err = lp.New("gpfs_num_opens", m.tags, m.meta, map[string]interface{}{"value": numOpens}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// number of closes
@@ -195,7 +195,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			}
 			y, err = lp.New("gpfs_num_closes", m.tags, m.meta, map[string]interface{}{"value": numCloses}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// number of reads
@@ -206,7 +206,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			}
 			y, err = lp.New("gpfs_num_reads", m.tags, m.meta, map[string]interface{}{"value": numReads}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// number of writes
@@ -217,7 +217,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			}
 			y, err = lp.New("gpfs_num_writes", m.tags, m.meta, map[string]interface{}{"value": numWrites}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// number of read directories
@@ -228,7 +228,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			}
 			y, err = lp.New("gpfs_num_readdirs", m.tags, m.meta, map[string]interface{}{"value": numReaddirs}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 
 			// Number of inode updates
@@ -239,7 +239,7 @@ func (m *GpfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			}
 			y, err = lp.New("gpfs_num_inode_updates", m.tags, m.meta, map[string]interface{}{"value": numInodeUpdates}, timestamp)
 			if err == nil {
-				output <- y
+				output <- &y
 			}
 		}
 	}

collectors/infinibandMetric.go

@@ -140,7 +140,7 @@ func (m *InfinibandCollector) Init(config json.RawMessage) error {
 }
 
 // Read reads Infiniband counter files below IB_BASEPATH
-func (m *InfinibandCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *InfinibandCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 
 	// Check if already initialized
 	if !m.init {
@@ -156,7 +156,7 @@ func (m *InfinibandCollector) Read(interval time.Duration, output chan lp.CCMetr
 			if data, ok := readOneLine(counterFile); ok {
 				if v, err := strconv.ParseInt(data, 10, 64); err == nil {
 					if y, err := lp.New(counterName, info.tagSet, m.meta, map[string]interface{}{"value": v}, now); err == nil {
-						output <- y
+						output <- &y
 					}
 				}
 			}

collectors/infinibandPerfQueryMetric.go

@@ -108,7 +108,7 @@ func (m *InfinibandPerfQueryCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid string, port string, tags map[string]string, output chan lp.CCMetric) error {
+func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid string, port string, tags map[string]string, output chan *lp.CCMetric) error {
 
 	args := fmt.Sprintf("-r %s %s 0xf000", lid, port)
 	command := exec.Command(cmd, args)
@@ -127,7 +127,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 			if err == nil {
 				y, err := lp.New("ib_recv", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -137,7 +137,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 			if err == nil {
 				y, err := lp.New("ib_xmit", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -147,7 +147,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 			if err == nil {
 				y, err := lp.New("ib_recv_pkts", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -157,7 +157,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 			if err == nil {
 				y, err := lp.New("ib_xmit_pkts", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -167,7 +167,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 			if err == nil {
 				y, err := lp.New("ib_recv_pkts", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -177,7 +177,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 			if err == nil {
 				y, err := lp.New("ib_xmit_pkts", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 				if err == nil {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -185,7 +185,7 @@ func (m *InfinibandPerfQueryCollector) doPerfQuery(cmd string, dev string, lid s
 	return nil
 }
 
-func (m *InfinibandPerfQueryCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *InfinibandPerfQueryCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 
 	if m.init {
 		for dev, ports := range m.lids {
@@ -203,7 +203,7 @@ func (m *InfinibandPerfQueryCollector) Read(interval time.Duration, output chan
 					if err == nil {
 						y, err := lp.New("ib_recv", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 						if err == nil {
-							output <- y
+							output <- &y
 						}
 					}
 				}
@@ -214,7 +214,7 @@ func (m *InfinibandPerfQueryCollector) Read(interval time.Duration, output chan
 					if err == nil {
 						y, err := lp.New("ib_xmit", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 						if err == nil {
-							output <- y
+							output <- &y
 						}
 					}
 				}
@@ -225,7 +225,7 @@ func (m *InfinibandPerfQueryCollector) Read(interval time.Duration, output chan
 					if err == nil {
 						y, err := lp.New("ib_recv_pkts", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 						if err == nil {
-							output <- y
+							output <- &y
 						}
 					}
 				}
@@ -236,7 +236,7 @@ func (m *InfinibandPerfQueryCollector) Read(interval time.Duration, output chan
 					if err == nil {
 						y, err := lp.New("ib_xmit_pkts", tags, m.meta, map[string]interface{}{"value": float64(v)}, time.Now())
 						if err == nil {
-							output <- y
+							output <- &y
 						}
 					}
 				}

collectors/ipmiMetric.go

@@ -9,6 +9,7 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -53,7 +54,7 @@ func (m *IpmiCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *IpmiCollector) readIpmiTool(cmd string, output chan lp.CCMetric) {
+func (m *IpmiCollector) readIpmiTool(cmd string, output chan *lp.CCMetric) {
 	command := exec.Command(cmd, "sensor")
 	command.Wait()
 	stdout, err := command.Output()
@@ -86,13 +87,13 @@ func (m *IpmiCollector) readIpmiTool(cmd string, output chan lp.CCMetric) {
 			y, err := lp.New(name, map[string]string{"type": "node"}, m.meta, map[string]interface{}{"value": v}, time.Now())
 			if err == nil {
 				y.AddMeta("unit", unit)
-				output <- y
+				output <- &y
 			}
 		}
 	}
 }
 
-func (m *IpmiCollector) readIpmiSensors(cmd string, output chan lp.CCMetric) {
+func (m *IpmiCollector) readIpmiSensors(cmd string, output chan *lp.CCMetric) {
 
 	command := exec.Command(cmd, "--comma-separated-output", "--sdr-cache-recreate")
 	command.Wait()
@@ -115,14 +116,14 @@ func (m *IpmiCollector) readIpmiSensors(cmd string, output chan lp.CCMetric) {
 					if len(lv) > 4 {
 						y.AddMeta("unit", lv[4])
 					}
-					output <- y
+					output <- &y
 				}
 			}
 		}
 	}
 }
 
-func (m *IpmiCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *IpmiCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if len(m.config.IpmitoolPath) > 0 {
 		_, err := os.Stat(m.config.IpmitoolPath)
 		if err == nil {

collectors/likwidMetric.go

@@ -20,6 +20,7 @@ import (
 	"strings"
 	"time"
 	"unsafe"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 	"gopkg.in/Knetic/govaluate.v2"
 )
@@ -183,7 +184,7 @@ func (m *LikwidCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *LikwidCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *LikwidCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -269,7 +270,7 @@ func (m *LikwidCollector) Read(interval time.Duration, output chan lp.CCMetric)
 							map[string]interface{}{"value": m.mresults[i][tid][metric.Name]},
 							time.Now())
 						if err == nil {
-							output <- y
+							output <- &y
 						}
 					}
 				} else if metric.Scope.String() == "hwthread" {
@@ -281,7 +282,7 @@ func (m *LikwidCollector) Read(interval time.Duration, output chan lp.CCMetric)
 							map[string]interface{}{"value": m.mresults[i][tid][metric.Name]},
 							time.Now())
 						if err == nil {
-							output <- y
+							output <- &y
 						}
 					}
 				}
@@ -300,7 +301,7 @@ func (m *LikwidCollector) Read(interval time.Duration, output chan lp.CCMetric)
 						map[string]interface{}{"value": m.gmresults[tid][metric.Name]},
 						time.Now())
 					if err == nil {
-						output <- y
+						output <- &y
 					}
 				}
 			} else {
@@ -312,7 +313,7 @@ func (m *LikwidCollector) Read(interval time.Duration, output chan lp.CCMetric)
 						map[string]interface{}{"value": m.gmresults[tid][metric.Name]},
 						time.Now())
 					if err == nil {
-						output <- y
+						output <- &y
 					}
 				}
 			}

collectors/loadavgMetric.go

@@ -6,6 +6,7 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -40,7 +41,7 @@ func (m *LoadavgCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *LoadavgCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *LoadavgCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	var skip bool
 	if !m.init {
 		return
@@ -58,7 +59,7 @@ func (m *LoadavgCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, name)
 			y, err := lp.New(name, m.tags, m.meta, map[string]interface{}{"value": float64(x)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 	}
@@ -69,7 +70,7 @@ func (m *LoadavgCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, name)
 			y, err := lp.New(name, m.tags, m.meta, map[string]interface{}{"value": float64(x)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 	}

collectors/lustreMetric.go

@@ -8,6 +8,7 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -64,7 +65,7 @@ func (m *LustreCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *LustreCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *LustreCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -93,7 +94,7 @@ func (m *LustreCollector) Read(interval time.Duration, output chan lp.CCMetric)
 									if strings.Contains(name, "byte") {
 										y.AddMeta("unit", "Byte")
 									}
-									output <- y
+									output <- &y
 								}
 							}
 						}

collectors/memstatMetric.go

@@ -66,7 +66,7 @@ func (m *MemstatCollector) Init(config json.RawMessage) error {
 	return err
 }
 
-func (m *MemstatCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *MemstatCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -100,7 +100,7 @@ func (m *MemstatCollector) Read(interval time.Duration, output chan lp.CCMetric)
 		}
 		y, err := lp.New(name, m.tags, m.meta, map[string]interface{}{"value": int(float64(m.stats[match]) * 1.0e-3)}, time.Now())
 		if err == nil {
-			output <- y
+			output <- &y
 		}
 	}
 
@@ -111,7 +111,7 @@ func (m *MemstatCollector) Read(interval time.Duration, output chan lp.CCMetric)
 				_, skip := stringArrayContains(m.config.ExcludeMetrics, "mem_used")
 				y, err := lp.New("mem_used", m.tags, m.meta, map[string]interface{}{"value": int(float64(memUsed) * 1.0e-3)}, time.Now())
 				if err == nil && !skip {
-					output <- y
+					output <- &y
 				}
 			}
 		}
@@ -120,7 +120,7 @@ func (m *MemstatCollector) Read(interval time.Duration, output chan lp.CCMetric)
 		_, skip := stringArrayContains(m.config.ExcludeMetrics, "mem_shared")
 		y, err := lp.New("mem_shared", m.tags, m.meta, map[string]interface{}{"value": int(float64(m.stats[`MemShared`]) * 1.0e-3)}, time.Now())
 		if err == nil && !skip {
-			output <- y
+			output <- &y
 		}
 	}
 }

collectors/metricCollector.go

@@ -17,7 +17,7 @@ type MetricCollector interface {
 	Name() string
 	Init(config json.RawMessage) error
 	Initialized() bool
-	Read(duration time.Duration, output chan lp.CCMetric)
+	Read(duration time.Duration, output chan *lp.CCMetric)
 	Close()
 }
 

collectors/netstatMetric.go

@@ -7,6 +7,7 @@ import (
 	"strconv"
 	"strings"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -46,7 +47,7 @@ func (m *NetstatCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *NetstatCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *NetstatCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	data, err := ioutil.ReadFile(string(NETSTATFILE))
 	if err != nil {
 		log.Print(err.Error())
@@ -81,7 +82,7 @@ func (m *NetstatCollector) Read(interval time.Duration, output chan lp.CCMetric)
 					case strings.Contains(name, "pkt"):
 						y.AddMeta("unit", "Packets")
 					}
-					output <- y
+					output <- &y
 				}
 			}
 		}

collectors/nfsMetric.go

@@ -119,7 +119,7 @@ func (m *NfsCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *NfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *NfsCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -136,7 +136,7 @@ func (m *NfsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 			y, err := lp.New(fmt.Sprintf("nfs_%s", name), m.tags, m.meta, map[string]interface{}{"value": value}, timestamp)
 			if err == nil {
 				y.AddMeta("version", version)
-				output <- y
+				output <- &y
 			}
 		}
 	}

collectors/nvidiaMetric.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"log"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 	"github.com/NVIDIA/go-nvml/pkg/nvml"
 )
@@ -55,7 +56,7 @@ func (m *NvidiaCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *NvidiaCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -76,12 +77,12 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_util")
 			y, err := lp.New("nv_util", tags, m.meta, map[string]interface{}{"value": float64(util.Gpu)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_mem_util")
 			y, err = lp.New("nv_mem_util", tags, m.meta, map[string]interface{}{"value": float64(util.Memory)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -92,14 +93,14 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			y, err := lp.New("nv_mem_total", tags, m.meta, map[string]interface{}{"value": t}, time.Now())
 			if err == nil && !skip {
 				y.AddMeta("unit", "MByte")
-				output <- y
+				output <- &y
 			}
 			f := float64(meminfo.Used) / (1024 * 1024)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_fb_memory")
 			y, err = lp.New("nv_fb_memory", tags, m.meta, map[string]interface{}{"value": f}, time.Now())
 			if err == nil && !skip {
 				y.AddMeta("unit", "MByte")
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -109,7 +110,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			y, err := lp.New("nv_temp", tags, m.meta, map[string]interface{}{"value": float64(temp)}, time.Now())
 			if err == nil && !skip {
 				y.AddMeta("unit", "degC")
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -118,7 +119,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_fan")
 			y, err := lp.New("nv_fan", tags, m.meta, map[string]interface{}{"value": float64(fan)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -136,13 +137,13 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			}
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_ecc_mode")
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		} else if ret == nvml.ERROR_NOT_SUPPORTED {
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_ecc_mode")
 			y, err := lp.New("nv_ecc_mode", tags, m.meta, map[string]interface{}{"value": string("N/A")}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -151,7 +152,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_perf_state")
 			y, err := lp.New("nv_perf_state", tags, m.meta, map[string]interface{}{"value": fmt.Sprintf("P%d", int(pstate))}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -160,7 +161,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_power_usage_report")
 			y, err := lp.New("nv_power_usage_report", tags, m.meta, map[string]interface{}{"value": float64(power) / 1000}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -169,7 +170,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_graphics_clock_report")
 			y, err := lp.New("nv_graphics_clock_report", tags, m.meta, map[string]interface{}{"value": float64(gclk)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -178,7 +179,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_sm_clock_report")
 			y, err := lp.New("nv_sm_clock_report", tags, m.meta, map[string]interface{}{"value": float64(smclk)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -187,7 +188,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_mem_clock_report")
 			y, err := lp.New("nv_mem_clock_report", tags, m.meta, map[string]interface{}{"value": float64(memclk)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -196,7 +197,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_max_graphics_clock")
 			y, err := lp.New("nv_max_graphics_clock", tags, m.meta, map[string]interface{}{"value": float64(max_gclk)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -205,7 +206,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_max_sm_clock")
 			y, err := lp.New("nv_max_sm_clock", tags, m.meta, map[string]interface{}{"value": float64(max_smclk)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -214,7 +215,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_max_mem_clock")
 			y, err := lp.New("nv_max_mem_clock", tags, m.meta, map[string]interface{}{"value": float64(max_memclk)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -223,7 +224,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_ecc_db_error")
 			y, err := lp.New("nv_ecc_db_error", tags, m.meta, map[string]interface{}{"value": float64(ecc_db)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -232,7 +233,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_ecc_sb_error")
 			y, err := lp.New("nv_ecc_sb_error", tags, m.meta, map[string]interface{}{"value": float64(ecc_sb)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -241,7 +242,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_power_man_limit")
 			y, err := lp.New("nv_power_man_limit", tags, m.meta, map[string]interface{}{"value": float64(pwr_limit)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -250,7 +251,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_encoder_util")
 			y, err := lp.New("nv_encoder_util", tags, m.meta, map[string]interface{}{"value": float64(enc_util)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 
@@ -259,7 +260,7 @@ func (m *NvidiaCollector) Read(interval time.Duration, output chan lp.CCMetric)
 			_, skip = stringArrayContains(m.config.ExcludeMetrics, "nv_decoder_util")
 			y, err := lp.New("nv_decoder_util", tags, m.meta, map[string]interface{}{"value": float64(dec_util)}, time.Now())
 			if err == nil && !skip {
-				output <- y
+				output <- &y
 			}
 		}
 	}

collectors/tempMetric.go

@@ -4,12 +4,13 @@ import (
 	"encoding/json"
 	"fmt"
 	"io/ioutil"
-	cclog "github.com/ClusterCockpit/cc-metric-collector/internal/ccLogger"
 	"os"
 	"path/filepath"
 	"strconv"
 	"strings"
 	"time"
+
+	cclog "github.com/ClusterCockpit/cc-metric-collector/internal/ccLogger"
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -75,7 +76,7 @@ func get_hwmon_sensors() (map[string]map[string]string, error) {
 	return sensors, nil
 }
 
-func (m *TempCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *TempCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 
 	sensors, err := get_hwmon_sensors()
 	if err != nil {
@@ -103,7 +104,7 @@ func (m *TempCollector) Read(interval time.Duration, output chan lp.CCMetric) {
 				y, err := lp.New(strings.ToLower(mname), tags, m.meta, map[string]interface{}{"value": int(float64(x) / 1000)}, time.Now())
 				if err == nil {
 					cclog.ComponentDebug(m.name, y)
-					output <- y
+					output <- &y
 				}
 			}
 		}

collectors/topprocsMetric.go

@@ -8,6 +8,7 @@ import (
 	"os/exec"
 	"strings"
 	"time"
+
 	lp "github.com/ClusterCockpit/cc-metric-collector/internal/ccMetric"
 )
 
@@ -51,7 +52,7 @@ func (m *TopProcsCollector) Init(config json.RawMessage) error {
 	return nil
 }
 
-func (m *TopProcsCollector) Read(interval time.Duration, output chan lp.CCMetric) {
+func (m *TopProcsCollector) Read(interval time.Duration, output chan *lp.CCMetric) {
 	if !m.init {
 		return
 	}
@@ -68,7 +69,7 @@ func (m *TopProcsCollector) Read(interval time.Duration, output chan lp.CCMetric
 		name := fmt.Sprintf("topproc%d", i)
 		y, err := lp.New(name, m.tags, m.meta, map[string]interface{}{"value": string(lines[i])}, time.Now())
 		if err == nil {
-			output <- y
+			output <- &y
 		}
 	}
 }