ClusterCockpit/cc-metric-collector
1
0
Fork 0
mirror of https://github.com/ClusterCockpit/cc-metric-collector.git synced 2024-12-27 07:39:05 +01:00
Code Issues Packages Projects Releases Wiki Activity

Avoid unneccessary memory allocations

Browse Source
This commit is contained in:
Holger Obermaier 2023-09-21 10:19:25 +02:00
parent a401e4cdd1
commit 7b5a4caf6a
1 changed files with 20 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
sinks/httpSink.go
View File

@ -47,11 +47,18 @@ type HttpSinkConfig struct {
MaxRetries int `json:"max_retries,omitempty"` MaxRetries int `json:"max_retries,omitempty"`
} }
type key_value_pair struct {
key string
value string
}
type HttpSink struct { type HttpSink struct {
sink sink
client *http.Client client *http.Client
// influx line protocol encoder // influx line protocol encoder
encoder influx.Encoder encoder influx.Encoder
// List of tags and meta data tags which should be used as tags
extended_tag_list []key_value_pair
// Flush() runs in another goroutine and accesses the influx line protocol encoder, // Flush() runs in another goroutine and accesses the influx line protocol encoder,
// so this encoderLock has to protect the encoder // so this encoderLock has to protect the encoder
encoderLock sync.Mutex encoderLock sync.Mutex
@ -74,16 +81,12 @@ func (s *HttpSink) Write(m lp.CCMetric) error {
s.encoder.StartLine(m.Name()) s.encoder.StartLine(m.Name())
// copy tags and meta data which should be used as tags // copy tags and meta data which should be used as tags
type key_value struct { s.extended_tag_list = s.extended_tag_list[:0]
key string
value string
}
key_value_store := make([]key_value, 0)
for key, value := range m.Tags() { for key, value := range m.Tags() {
key_value_store = s.extended_tag_list =
append( append(
key_value_store, s.extended_tag_list,
key_value{ key_value_pair{
key: key, key: key,
value: value, value: value,
}, },
@ -91,10 +94,10 @@ func (s *HttpSink) Write(m lp.CCMetric) error {
} }
for _, key := range s.config.MetaAsTags { for _, key := range s.config.MetaAsTags {
if value, ok := m.GetMeta(key); ok { if value, ok := m.GetMeta(key); ok {
key_value_store = s.extended_tag_list =
append( append(
key_value_store, s.extended_tag_list,
key_value{ key_value_pair{
key: key, key: key,
value: value, value: value,
}, },
@ -104,8 +107,8 @@ func (s *HttpSink) Write(m lp.CCMetric) error {
// Encode tags (they musts be in lexical order) // Encode tags (they musts be in lexical order)
slices.SortFunc( slices.SortFunc(
key_value_store, s.extended_tag_list,
func(a key_value, b key_value) int { func(a key_value_pair, b key_value_pair) int {
if a.key < b.key { if a.key < b.key {
return -1 return -1
} }
@ -115,10 +118,10 @@ func (s *HttpSink) Write(m lp.CCMetric) error {
return 0 return 0
}, },
) )
for i := range key_value_store { for i := range s.extended_tag_list {
s.encoder.AddTag( s.encoder.AddTag(
key_value_store[i].key, s.extended_tag_list[i].key,
key_value_store[i].value, s.extended_tag_list[i].value,
) )
} }
@ -309,6 +312,6 @@ func NewHttpSink(name string, config json.RawMessage) (Sink, error) {
// Configure influx line protocol encoder // Configure influx line protocol encoder
s.encoder.SetPrecision(influx.Nanosecond) s.encoder.SetPrecision(influx.Nanosecond)
s.extended_tag_list = make([]key_value_pair, 0)
return s, nil return s, nil
} }