Embedded types should be at the top of the field list of a struct.

And there should be an empty line separating embedded fields from regular fields

collectors/rocmsmiMetric.go

@@ -38,6 +38,7 @@ type RocmSmiCollectorDevice struct {
 
 type RocmSmiCollector struct {
 	metricCollector
+
 	config  RocmSmiCollectorConfig // the configuration structure
 	devices []RocmSmiCollectorDevice
 }