Limit verbosity a bit (SCHEDD_DEBUG=D_FULLDEBUG).

CMakeLists.txt

@@ -42,3 +42,5 @@ target_include_directories(htcondor_cc_sync_plugin PRIVATE ${CMAKE_SOURCE_DIR}/c
 
 target_compile_options(htcondor_cc_sync_plugin PRIVATE
     -DCONDOR_VERSION=\"10.0.0\" -DENABLE_STATE_DUMP -DGLIBC219=GLIBC219 -DGLIBC=GLIBC -DHAVE_CONFIG_H -DLINUX=\"LINUX_3.13.0-30-GENERIC\" -DPLATFORM=\"X86_64-Linux_17\" -DPRE_RELEASE_STR=\"\" -DWITH_OPENSSL -DX86_64=X86_64 -Dcondorapi_shared_EXPORTS -DWITH_IPV6)
+
+target_compile_definitions(htcondor_cc_sync_plugin PRIVATE $<$<OR:$<STREQUAL:${CMAKE_BUILD_TYPE},Debug>,$<STREQUAL:${CMAKE_BUILD_TYPE},RelWithDebInfo>>:VERBOSE>)

ReadMe.md

@@ -38,3 +38,5 @@ CCSYNC_SUBMIT_ID=<Unique submission node id, expected to be in 0..3 (see #global
     }
 }
 ```
+
+For getting a debug dump of the class ads at the end of the `endTransaction`, build with `-DVERBOSE` (automatically set for `Debug` or `RelWithDebInfo` builds) and set `SCHEDD_DEBUG=D_FULLDEBUG` in the condor config.

src/htcondor_cc_sync_plugin.cpp

@@ -252,17 +252,16 @@ std::uint64_t CCSyncPlugin::globalJobIdToInt(const JobId jobId) {
 }
 
 void printJobStatus(const JobId jobId, const CondorJob &job) {
-  dprintf(D_ALWAYS, "=============== Job ClassAds: %d.%d\n", jobId.first,
+  dprintf(D_VERBOSE, "=============== Job ClassAds: %d.%d\n", jobId.first,
           jobId.second);
   for (auto value : job) {
-    dprintf(D_ALWAYS, "%s: %s\n", value.first.c_str(), value.second.c_str());
+    dprintf(D_VERBOSE, "%s: %s\n", value.first.c_str(), value.second.c_str());
   }
-  dprintf(D_ALWAYS, "=============== End Job ClassAds: %d.%d\n", jobId.first,
+  dprintf(D_VERBOSE, "=============== End Job ClassAds: %d.%d\n", jobId.first,
           jobId.second);
 }
 
 std::string getRemoteHost(std::string_view slot) {
-  return "uller";
   auto atIt = std::find(slot.begin(), slot.end(), '@');
   auto subIt = std::find(atIt, slot.end(), '.');
   return {++atIt, subIt};
@@ -323,7 +322,7 @@ std::string removeQuotes(const std::string &value) {
 
 void CCSyncPlugin::sendPostRequest(const std::string &route,
                                    const std::string &body) const noexcept {
-  dprintf(D_ALWAYS, "POST body: %s\n", body.c_str());
+  dprintf(D_VERBOSE, "POST body: %s\n", body.c_str());
   try {
     curlpp::Easy request;
     request.setOpt(curlpp::options::Url(url + route));
@@ -341,18 +340,20 @@ void CCSyncPlugin::sendPostRequest(const std::string &route,
     std::stringstream buf;
     request.setOpt(curlpp::options::WriteStream(&buf));
 
+#ifdef CURL_DEBUG
     request.setOpt(curlpp::options::DebugFunction(
         [](curl_infotype type, char *ptr, unsigned long length) -> int {
           // todo: eh.. if we need a length, are we potentially reading
           // oob??
-          dprintf(D_ALWAYS, "%d: %s\n", type, ptr);
+          dprintf(D_VERBOSE, "%d: %s\n", type, ptr);
           return length;
         }));
-    // request.setOpt(curlpp::options::Verbose(true));
+    request.setOpt(curlpp::options::Verbose(true));
+#endif
 
     request.perform();
 
-    dprintf(D_ALWAYS, "response: %s\n", buf.str().c_str());
+    dprintf(D_VERBOSE, "response: %s\n", buf.str().c_str());
   } catch (const curlpp::LogicError &e) {
     dprintf(D_ALWAYS, "LogicError: %s\n", e.what());
   } catch (const curlpp::RuntimeError &e) {
@@ -364,41 +365,6 @@ void CCSyncPlugin::sendPostRequest(const std::string &route,
   }
 }
 
-// std::unordered_map<std::string, std::string> parseToE(const std::string &toe)
-// {
-//   // toe = "[ Who = "itself"; How = "OF_ITS_OWN_ACCORD"; ExitCode = 2;
-//   HowCode =
-//   // 0; When = 1671108732; ExitBySignal = false ]";
-//   auto start = toe.find_first_not_of("[ ");
-//   auto stop = toe.find_last_not_of("] ");
-//   std::istringstream toeStream{toe.substr(start + 1, stop - start)};
-
-//   std::unordered_map<std::string, std::string> map;
-
-//   std::string element;
-//   while (std::getline(toeStream, element, ';')) {
-//     auto splitter = element.find(" = ");
-//     auto key = element.substr(0, splitter);
-//     auto value = element.substr(splitter + sizeof(" = "));
-//     map.emplace(key, value);
-//     dprintf(D_ALWAYS, "ToE field '%s': '%s'\n", key.c_str(), value.c_str());
-//   }
-
-//   return map;
-// }
-
-// std::uint64_t getEndTime(const CondorJob &job) {
-//   if (auto toeIt = job.find("ToE"); toeIt != job.end()) {
-//     auto toe = parseToE(toeIt->second);
-//     if (auto whenIt = toe.find("When"); whenIt != toe.end())
-//       return std::stoull(whenIt->second); // todo: always an int here?
-//   } else if (auto enteredStateTimeIt = job.find("EnteredCurrentStatus");
-//              enteredStateTimeIt != job.end()) {
-//     return std::stoull(enteredStateTimeIt->second);
-//   }
-//   return 0;
-// }
-
 void CCSyncPlugin::endTransaction() {
   if (initializing) { // HTCondor bug? We should'n be receiving events before
                       // initialization is done. We will ignore them if it
@@ -411,20 +377,23 @@ void CCSyncPlugin::endTransaction() {
   // dprintf(D_FULLDEBUG,"Ending transaction.\n");
 
   for (auto jobId : toConsider) {
+    try {
       if (jobId.second == -1)
         continue; // don't care about the "template"
 
       auto &job = currentStatus[jobId.first][jobId.second];
+#ifdef VERBOSE
       printJobStatus(jobId, job);
+#endif
       if (job.empty() || !jobHasRequiredClassAds(job))
         continue; // not yet ready
 
-    dprintf(D_ALWAYS, "JobStatus: %s\n", job["JobStatus"].c_str());
+      dprintf(D_VERBOSE, "JobStatus: %s\n", job["JobStatus"].c_str());
       int state = std::stoi(job["JobStatus"]), lastState;
 
       if (auto lastStateIt = job.find("LastJobStatus");
           lastStateIt != job.end()) {
-      dprintf(D_ALWAYS, "LastJobStatus: %s\n", lastStateIt->second.c_str());
+        dprintf(D_VERBOSE, "LastJobStatus: %s\n", lastStateIt->second.c_str());
         if (lastState = std::stoi(lastStateIt->second); lastState == state)
           continue;
       } else
@@ -476,6 +445,11 @@ void CCSyncPlugin::endTransaction() {
 
         sendPostRequest("/api/jobs/stop_job/", j.dump());
       }
+    } catch (const std::exception &e) {
+      dprintf(D_ALWAYS, "exception: %s\n", e.what());
+    } catch (...) {
+      dprintf(D_ALWAYS, "unknown exception\n");
+    }
   }
 
   toConsider.clear();