From dc7407d0f0d2a86777d75f9ab32faa356d0ef35a Mon Sep 17 00:00:00 2001 From: Jan Eitzinger Date: Wed, 11 Mar 2026 07:50:53 +0100 Subject: [PATCH] fix: prevent segvault if enable-job-taggers option is tru but tagger config directories are missing Entire-Checkpoint: 9ec86e3669e1 --- internal/tagger/tagger.go | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/internal/tagger/tagger.go b/internal/tagger/tagger.go index 5ee27e08..5ade4ebd 100644 --- a/internal/tagger/tagger.go +++ b/internal/tagger/tagger.go @@ -67,18 +67,20 @@ type JobTagger struct { func newTagger() { jobTagger = &JobTagger{} jobTagger.startTaggers = make([]Tagger, 0) - jobTagger.startTaggers = append(jobTagger.startTaggers, &AppTagger{}) jobTagger.stopTaggers = make([]Tagger, 0) - jobTagger.stopTaggers = append(jobTagger.stopTaggers, &JobClassTagger{}) - for _, tagger := range jobTagger.startTaggers { - if err := tagger.Register(); err != nil { + for _, t := range []Tagger{&AppTagger{}} { + if err := t.Register(); err != nil { cclog.Errorf("failed to register start tagger: %s", err) + } else { + jobTagger.startTaggers = append(jobTagger.startTaggers, t) } } - for _, tagger := range jobTagger.stopTaggers { - if err := tagger.Register(); err != nil { + for _, t := range []Tagger{&JobClassTagger{}} { + if err := t.Register(); err != nil { cclog.Errorf("failed to register stop tagger: %s", err) + } else { + jobTagger.stopTaggers = append(jobTagger.stopTaggers, t) } } }