ClusterCockpit/cc-backend
1
0
Fork 0
mirror of https://github.com/ClusterCockpit/cc-backend synced 2024-12-25 12:59:06 +01:00
Code Issues Packages Releases Activity

fix: add missing parameters for correct shared metric thresholds

Browse Source
This commit is contained in:
Christoph Kluge 2024-12-20 17:15:02 +01:00
parent 7c9182e0b0
commit bce536b9b4
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/frontend/src/generic/plots/MetricPlot.svelte
View File

@ -50,7 +50,7 @@
} }
// removed arg "subcluster": input metricconfig and topology now directly derived from subcluster // removed arg "subcluster": input metricconfig and topology now directly derived from subcluster
function findThresholds( function findJobAggregationThresholds(
subClusterTopology, subClusterTopology,
metricConfig, metricConfig,
scope, scope,
@ -60,7 +60,7 @@
) { ) {
if (!subClusterTopology || !metricConfig || !scope) { if (!subClusterTopology || !metricConfig || !scope) {
console.warn("Argument missing for findThresholds!"); console.warn("Argument missing for findJobAggregationThresholds!");
return null; return null;
} }
@ -96,7 +96,7 @@
else if (scope == "hwthread") divisor = subClusterTopology.core.length; // alt. name for core else if (scope == "hwthread") divisor = subClusterTopology.core.length; // alt. name for core
else if (scope == "accelerator") divisor = subClusterTopology.accelerators.length; else if (scope == "accelerator") divisor = subClusterTopology.accelerators.length;
else { else {
console.log('Unknown scope, return default thresholds ', scope) console.log('Unknown scope, return default aggregation thresholds ', scope)
divisor = 1; divisor = 1;
} }
@ -157,7 +157,7 @@
caution: "rgba(255, 128, 0, 0.3)", caution: "rgba(255, 128, 0, 0.3)",
alert: "rgba(255, 0, 0, 0.3)", alert: "rgba(255, 0, 0, 0.3)",
}; };
const thresholds = findThresholds( const thresholds = findJobAggregationThresholds(
subClusterTopology, subClusterTopology,
metricConfig, metricConfig,
scope, scope,

4
web/frontend/src/job/Metric.svelte
View File

@ -213,6 +213,8 @@
timestep={data.timestep} timestep={data.timestep}
scope={selectedScope} scope={selectedScope}
metric={metricName} metric={metricName}
numaccs={job.numAcc}
numhwthreads={job.numHWThreads}
{series} {series}
{isShared} {isShared}
{zoomState} {zoomState}
@ -226,6 +228,8 @@
timestep={data.timestep} timestep={data.timestep}
scope={selectedScope} scope={selectedScope}
metric={metricName} metric={metricName}
numaccs={job.numAcc}
numhwthreads={job.numHWThreads}
{series} {series}
{isShared} {isShared}
{zoomState} {zoomState}