Revert to blocking startJob REST api

Fixes #316

internal/repository/dbConnection.go

@@ -82,8 +82,6 @@ func Connect(driver string, db string) {
 		if err != nil {
 			log.Fatal(err)
 		}
-
-		startJobStartWorker()
 	})
 }
 

internal/repository/jobStartWorker.go

@@ -1,83 +0,0 @@
-// Copyright (C) NHR@FAU, University Erlangen-Nuremberg.
-// All rights reserved.
-// Use of this source code is governed by a MIT-style
-// license that can be found in the LICENSE file.
-package repository
-
-import (
-	"sync"
-	"time"
-
-	"github.com/ClusterCockpit/cc-backend/pkg/log"
-	"github.com/ClusterCockpit/cc-backend/pkg/schema"
-)
-
-type JobWithUser struct {
-	Job  *schema.JobMeta
-	User *schema.User
-}
-
-var (
-	jobStartPending sync.WaitGroup
-	jobStartChannel chan JobWithUser
-)
-
-func startJobStartWorker() {
-	jobStartChannel = make(chan JobWithUser, 128)
-
-	go jobStartWorker()
-}
-
-// Archiving worker thread
-func jobStartWorker() {
-	for {
-		select {
-		case req, ok := <-jobStartChannel:
-			if !ok {
-				break
-			}
-			jobRepo := GetJobRepository()
-			var id int64
-
-			for i := 0; i < 5; i++ {
-				var err error
-
-				id, err = jobRepo.Start(req.Job)
-				if err != nil {
-					log.Errorf("Attempt %d: insert into database failed: %v", i, err)
-				} else {
-					break
-				}
-				time.Sleep(1 * time.Second)
-			}
-
-			for _, tag := range req.Job.Tags {
-				if _, err := jobRepo.AddTagOrCreate(req.User, id,
-					tag.Type, tag.Name, tag.Scope); err != nil {
-					log.Errorf("adding tag to new job %d failed: %v", id, err)
-				}
-			}
-
-			log.Printf("new job (id: %d): cluster=%s, jobId=%d, user=%s, startTime=%d",
-				id, req.Job.Cluster, req.Job.JobID, req.Job.User, req.Job.StartTime)
-
-			jobStartPending.Done()
-		}
-	}
-}
-
-// Trigger async archiving
-func TriggerJobStart(req JobWithUser) {
-	if jobStartChannel == nil {
-		log.Fatal("Cannot start Job without jobStart channel. Did you Start the worker?")
-	}
-
-	jobStartPending.Add(1)
-	jobStartChannel <- req
-}
-
-// Wait for background thread to finish pending archiving operations
-func WaitForJobStart() {
-	// close channel and wait for worker to process remaining jobs
-	jobStartPending.Wait()
-}