Add Rate Limiting based on IP and username

This commit is contained in:
exterr2f
2025-02-14 12:41:28 +01:00
parent 43cb1f1bff
commit b6b37ee68b
3 changed files with 51 additions and 2 deletions

View File

@@ -10,11 +10,14 @@ import (
"database/sql"
"encoding/base64"
"errors"
"net"
"net/http"
"os"
"sync"
"time"
"golang.org/x/time/rate"
"github.com/ClusterCockpit/cc-backend/internal/config"
"github.com/ClusterCockpit/cc-backend/internal/repository"
"github.com/ClusterCockpit/cc-backend/pkg/log"
@@ -32,6 +35,29 @@ var (
authInstance *Authentication
)
var (
ipLimiters sync.Map
usernameLimiters sync.Map
)
func getIPLimiter(ip string) *rate.Limiter {
limiter, ok := ipLimiters.Load(ip)
if !ok {
limiter = rate.NewLimiter(rate.Every(time.Minute/5), 5)
ipLimiters.Store(ip, limiter)
}
return limiter.(*rate.Limiter)
}
func getUserLimiter(username string) *rate.Limiter {
limiter, ok := usernameLimiters.Load(username)
if !ok {
limiter = rate.NewLimiter(rate.Every(time.Hour/10), 10)
usernameLimiters.Store(username, limiter)
}
return limiter.(*rate.Limiter)
}
type Authentication struct {
sessionStore *sessions.CookieStore
LdapAuth *LdapAuthenticator
@@ -208,9 +234,29 @@ func (auth *Authentication) Login(
onfailure func(rw http.ResponseWriter, r *http.Request, loginErr error),
) http.Handler {
return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
username := r.FormValue("username")
var dbUser *schema.User
ip, _, err := net.SplitHostPort(r.RemoteAddr)
if err != nil {
ip = r.RemoteAddr
}
username := r.FormValue("username")
ipLimiter := getIPLimiter(ip)
userLimiter := getUserLimiter(username)
if !ipLimiter.Allow() {
log.Warnf("AUTH/RATE > Too many login attempts from IP %s", ip)
onfailure(rw, r, errors.New("too many login attempts, please try again later"))
return
}
if !userLimiter.Allow() {
log.Warnf("AUTH/RATE > Too many failed login attempts for user %s", username)
onfailure(rw, r, errors.New("too many login attempts for this user, please try again later"))
return
}
var dbUser *schema.User
if username != "" {
var err error
dbUser, err = repository.GetUserRepository().GetUser(username)