From 80be78604f066b64837170d0f41d4e54f8bf3a94 Mon Sep 17 00:00:00 2001 From: Jan Eitzinger Date: Wed, 23 Aug 2023 21:15:49 +0200 Subject: [PATCH 1/7] fix: Responsive Navbar Missing Burger menu icon --- web/frontend/package-lock.json | 20 +- web/frontend/package.json | 2 +- web/frontend/src/Header.svelte | 357 +++++++++++++++++++++++++-------- 3 files changed, 281 insertions(+), 98 deletions(-) diff --git a/web/frontend/package-lock.json b/web/frontend/package-lock.json index 7997e2e..eb80726 100644 --- a/web/frontend/package-lock.json +++ b/web/frontend/package-lock.json @@ -14,7 +14,7 @@ "chart.js": "^4.3.3", "graphql": "^16.6.0", "svelte-chartjs": "^3.1.2", - "sveltestrap": "^5.10.0", + "sveltestrap": "^5.11.1", "uplot": "^1.6.24", "wonka": "^6.3.2" }, @@ -138,9 +138,9 @@ } }, "node_modules/@rollup/plugin-node-resolve": { - "version": "15.2.0", - "resolved": "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-15.2.0.tgz", - "integrity": "sha512-mKur03xNGT8O9ODO6FtT43ITGqHWZbKPdVJHZb+iV9QYcdlhUUB0wgknvA4KCUmC5oHJF6O2W1EgmyOQyVUI4Q==", + "version": "15.2.1", + "resolved": "https://registry.npmjs.org/@rollup/plugin-node-resolve/-/plugin-node-resolve-15.2.1.tgz", + "integrity": "sha512-nsbUg588+GDSu8/NS8T4UAshO6xeaOfINNuXeVHcKV02LJtoRaM1SiOacClw4kws1SFiNhdLGxlbMY9ga/zs/w==", "dev": true, "dependencies": { "@rollup/pluginutils": "^5.0.1", @@ -346,9 +346,9 @@ "dev": true }, "node_modules/fsevents": { - "version": "2.3.2", - "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.2.tgz", - "integrity": "sha512-xiqMQR4xAeHTuB9uWm+fFRcIOgKBMiOBP+eXiyT7jsgVCq1bkVygt00oASowB7EdtpOHaaPgKt812P9ab+DDKA==", + "version": "2.3.3", + "resolved": "https://registry.npmjs.org/fsevents/-/fsevents-2.3.3.tgz", + "integrity": "sha512-5xoDfX+fL7faATnagmWPpbFtwh/R77WmMMqqHGS65C3vvB0YHrgF+B1YmZ3441tMj5n63k0212XNoJwzlhffQw==", "dev": true, "hasInstallScript": true, "optional": true, @@ -547,9 +547,9 @@ } }, "node_modules/rollup": { - "version": "3.28.0", - "resolved": "https://registry.npmjs.org/rollup/-/rollup-3.28.0.tgz", - "integrity": "sha512-d7zhvo1OUY2SXSM6pfNjgD5+d0Nz87CUp4mt8l/GgVP3oBsPwzNvSzyu1me6BSG9JIgWNTVcafIXBIyM8yQ3yw==", + "version": "3.28.1", + "resolved": "https://registry.npmjs.org/rollup/-/rollup-3.28.1.tgz", + "integrity": "sha512-R9OMQmIHJm9znrU3m3cpE8uhN0fGdXiawME7aZIpQqvpS/85+Vt1Hq1/yVIcYfOmaQiHjvXkQAoJukvLpau6Yw==", "devOptional": true, "bin": { "rollup": "dist/bin/rollup" diff --git a/web/frontend/package.json b/web/frontend/package.json index 4ef7314..b0bb5af 100644 --- a/web/frontend/package.json +++ b/web/frontend/package.json @@ -21,7 +21,7 @@ "chart.js": "^4.3.3", "graphql": "^16.6.0", "svelte-chartjs": "^3.1.2", - "sveltestrap": "^5.10.0", + "sveltestrap": "^5.11.1", "uplot": "^1.6.24", "wonka": "^6.3.2" } diff --git a/web/frontend/src/Header.svelte b/web/frontend/src/Header.svelte index 164a592..443f1d7 100644 --- a/web/frontend/src/Header.svelte +++ b/web/frontend/src/Header.svelte @@ -1,110 +1,293 @@ - + + - ClusterCockpit Logo + ClusterCockpit Logo (isOpen = !isOpen)} /> - (isOpen = detail.isOpen)}> - + From 204901189d1ea15522f74eab610fe73e01959aa5 Mon Sep 17 00:00:00 2001 From: Jan Eitzinger Date: Thu, 24 Aug 2023 09:22:12 +0200 Subject: [PATCH 2/7] Add NavbarLinks component --- web/frontend/src/Header.svelte | 140 ++++++++-------------------- web/frontend/src/NavbarLinks.svelte | 39 ++++++++ 2 files changed, 78 insertions(+), 101 deletions(-) create mode 100644 web/frontend/src/NavbarLinks.svelte diff --git a/web/frontend/src/Header.svelte b/web/frontend/src/Header.svelte index 443f1d7..eec8beb 100644 --- a/web/frontend/src/Header.svelte +++ b/web/frontend/src/Header.svelte @@ -17,6 +17,7 @@ DropdownItem, InputGroupText, } from "sveltestrap"; + import NavbarLinks from "./NavbarLinks.svelte"; export let username; // empty string if auth. is disabled, otherwise the username as string export let authlevel; // Integer @@ -118,122 +119,60 @@ > - diff --git a/web/frontend/src/NavbarLinks.svelte b/web/frontend/src/NavbarLinks.svelte new file mode 100644 index 0000000..6861da5 --- /dev/null +++ b/web/frontend/src/NavbarLinks.svelte @@ -0,0 +1,39 @@ + + +{#each links as item} + {#if !item.perCluster} + {item.title} + {:else} + + + + {item.title} + + + {#each clusters as cluster} + + {cluster.name} + + {/each} + + + {/if} +{/each} From 69b3f767f66d0c39664c708f9e4ff759604ce26a Mon Sep 17 00:00:00 2001 From: Jan Eitzinger Date: Thu, 24 Aug 2023 09:38:12 +0200 Subject: [PATCH 3/7] Make menu flat if collapsed --- web/frontend/src/Header.svelte | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/web/frontend/src/Header.svelte b/web/frontend/src/Header.svelte index eec8beb..abef959 100644 --- a/web/frontend/src/Header.svelte +++ b/web/frontend/src/Header.svelte @@ -9,12 +9,10 @@ NavbarBrand, Nav, NavItem, - NavLink, NavbarToggler, Dropdown, DropdownToggle, DropdownMenu, - DropdownItem, InputGroupText, } from "sveltestrap"; import NavbarLinks from "./NavbarLinks.svelte"; @@ -118,7 +116,7 @@ on:update={({ detail }) => (isOpen = detail.isOpen)} >