Run go fix

pkg/metricstore/avroHelper.go

@@ -9,6 +9,7 @@ import (
 	"context"
 	"slices"
 	"strconv"
+	"strings"
 	"sync"
 
 	cclog "github.com/ClusterCockpit/cc-lib/v2/ccLogger"
@@ -44,11 +45,11 @@ func DataStaging(wg *sync.WaitGroup, ctx context.Context) {
 							continue
 						}
 
-						metricName := ""
+						var metricName strings.Builder
 						for _, selectorName := range val.Selector {
-							metricName += selectorName + SelectorDelimiter
+							metricName.WriteString(selectorName + SelectorDelimiter)
 						}
-						metricName += val.MetricName
+						metricName.WriteString(val.MetricName)
 
 						var selector []string
 						selector = append(selector, val.Cluster, val.Node, strconv.FormatInt(freq, 10))
@@ -62,7 +63,7 @@ func DataStaging(wg *sync.WaitGroup, ctx context.Context) {
 						}
 
 						if avroLevel != nil {
-							avroLevel.addMetric(metricName, val.Value, val.Timestamp, int(freq))
+							avroLevel.addMetric(metricName.String(), val.Value, val.Timestamp, int(freq))
 						}
 					default:
 						// No more messages, exit
@@ -82,13 +83,13 @@ func DataStaging(wg *sync.WaitGroup, ctx context.Context) {
 					continue
 				}
 
-				metricName := ""
+				var metricName strings.Builder
 
 				for _, selectorName := range val.Selector {
-					metricName += selectorName + SelectorDelimiter
+					metricName.WriteString(selectorName + SelectorDelimiter)
 				}
 
-				metricName += val.MetricName
+				metricName.WriteString(val.MetricName)
 
 				// Create a new selector for the Avro level
 				// The selector is a slice of strings that represents the path to the
@@ -109,7 +110,7 @@ func DataStaging(wg *sync.WaitGroup, ctx context.Context) {
 				}
 
 				if avroLevel != nil {
-					avroLevel.addMetric(metricName, val.Value, val.Timestamp, int(freq))
+					avroLevel.addMetric(metricName.String(), val.Value, val.Timestamp, int(freq))
 				}
 			}
 		}

pkg/metricstore/metricstore_test.go

@@ -143,7 +143,7 @@ func TestHealthCheck(t *testing.T) {
 	// Setup test data for node003 - some metrics missing (no buffer)
 	node003 := ms.root.findLevelOrCreate([]string{"testcluster", "node003"}, len(metrics))
 	// Only create buffers for first two metrics
-	for i := 0; i < 2; i++ {
+	for i := range 2 {
 		node003.metrics[i] = newBuffer(startTime, 10)
 		for ts := startTime; ts <= now; ts += 10 {
 			node003.metrics[i].write(ts, schema.Float(float64(i+1)))