mirror of
				https://github.com/ClusterCockpit/cc-backend
				synced 2025-11-03 17:15:06 +01:00 
			
		
		
		
	fix: add compatibility for footprint metrics without config
This commit is contained in:
		@@ -67,8 +67,9 @@
 | 
			
		||||
  export let height = "310px";
 | 
			
		||||
 | 
			
		||||
  const footprintData = job?.footprint?.map((jf) => {
 | 
			
		||||
    // Unit
 | 
			
		||||
    const fmc = getContext("getMetricConfig")(job.cluster, job.subCluster, jf.name);
 | 
			
		||||
    if (fmc) {
 | 
			
		||||
      // Unit
 | 
			
		||||
      const unit = (fmc?.unit?.prefix ? fmc.unit.prefix : "") + (fmc?.unit?.base ? fmc.unit.base : "")
 | 
			
		||||
 | 
			
		||||
      // Threshold / -Differences
 | 
			
		||||
@@ -122,7 +123,18 @@
 | 
			
		||||
          impact: -1,
 | 
			
		||||
        };
 | 
			
		||||
      }
 | 
			
		||||
  });
 | 
			
		||||
    } else { // No matching metric config: display as single value
 | 
			
		||||
      return {
 | 
			
		||||
        name: jf.name + ' (' + jf.stat + ')',
 | 
			
		||||
        avg: jf.value,
 | 
			
		||||
        message:
 | 
			
		||||
          `No config for metric ${jf.name} found.`,
 | 
			
		||||
        impact: 4,
 | 
			
		||||
      };
 | 
			
		||||
    }
 | 
			
		||||
  }).sort(function (a, b) { // Sort by impact value primarily, within impact sort name alphabetically
 | 
			
		||||
    return a.impact - b.impact || ((a.name > b.name) ? 1 : ((b.name > a.name) ? -1 : 0));
 | 
			
		||||
  });;
 | 
			
		||||
 | 
			
		||||
  function evalFootprint(mean, thresholds, lowerIsBetter, level) {
 | 
			
		||||
    // Handle Metrics in which less value is better
 | 
			
		||||
@@ -159,6 +171,7 @@
 | 
			
		||||
  {/if}
 | 
			
		||||
  <CardBody>
 | 
			
		||||
    {#each footprintData as fpd, index}
 | 
			
		||||
      {#if fpd.impact !== 4}
 | 
			
		||||
        <div class="mb-1 d-flex justify-content-between">
 | 
			
		||||
          <div> <b>{fpd.name}</b></div>
 | 
			
		||||
          <!-- For symmetry, see below ...-->
 | 
			
		||||
@@ -213,6 +226,29 @@
 | 
			
		||||
          </Col>
 | 
			
		||||
          {/if}
 | 
			
		||||
        </Row>
 | 
			
		||||
      {:else}
 | 
			
		||||
        <div class="mb-1 d-flex justify-content-between">
 | 
			
		||||
          <div>
 | 
			
		||||
             <b>{fpd.name}</b>
 | 
			
		||||
          </div>
 | 
			
		||||
          <div
 | 
			
		||||
            class="cursor-help d-inline-flex"
 | 
			
		||||
            id={`footprint-${job.jobId}-${index}`}
 | 
			
		||||
          >
 | 
			
		||||
            <div class="mx-1">
 | 
			
		||||
              <Icon name="info-circle"/>
 | 
			
		||||
            </div>
 | 
			
		||||
            <div>
 | 
			
		||||
              {fpd.avg} 
 | 
			
		||||
            </div>
 | 
			
		||||
          </div>
 | 
			
		||||
        </div>
 | 
			
		||||
        <Tooltip
 | 
			
		||||
          target={`footprint-${job.jobId}-${index}`}
 | 
			
		||||
          placement="right"
 | 
			
		||||
          offset={[0, 20]}>{fpd.message}</Tooltip
 | 
			
		||||
        >
 | 
			
		||||
      {/if}
 | 
			
		||||
    {/each}
 | 
			
		||||
    {#if job?.metaData?.message}
 | 
			
		||||
      <hr class="mt-1 mb-2" />
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user