From 1feb3baf68af9cc6fe5a222013e9d8d47ff54ed8 Mon Sep 17 00:00:00 2001
From: Jan Eitzinger <jan@moebiusband.org>
Date: Tue, 10 Feb 2026 07:53:30 +0100
Subject: [PATCH] Create copy of test db before unit tests

---
 internal/repository/node_test.go       |  7 +++++++
 internal/repository/repository_test.go | 20 ++++++++++++++++++--
 internal/repository/stats_test.go      | 10 ++--------
 internal/repository/userConfig_test.go | 21 +++++++++++++++++++--
 4 files changed, 46 insertions(+), 12 deletions(-)

diff --git a/internal/repository/node_test.go b/internal/repository/node_test.go
index b863dc69..4286ab34 100644
--- a/internal/repository/node_test.go
+++ b/internal/repository/node_test.go
@@ -139,6 +139,13 @@ func nodeTestSetup(t *testing.T) {
 	}
 	archiveCfg := fmt.Sprintf("{\"kind\": \"file\",\"path\": \"%s\"}", jobarchive)
 
+	if err := ResetConnection(); err != nil {
+		t.Fatal(err)
+	}
+	t.Cleanup(func() {
+		ResetConnection()
+	})
+
 	Connect(dbfilepath)
 
 	if err := archive.Init(json.RawMessage(archiveCfg)); err != nil {
diff --git a/internal/repository/repository_test.go b/internal/repository/repository_test.go
index 34852830..b9496143 100644
--- a/internal/repository/repository_test.go
+++ b/internal/repository/repository_test.go
@@ -6,6 +6,8 @@ package repository
 
 import (
 	"context"
+	"os"
+	"path/filepath"
 	"testing"
 
 	"github.com/ClusterCockpit/cc-backend/internal/graph/model"
@@ -148,8 +150,22 @@ func getContext(tb testing.TB) context.Context {
 func setup(tb testing.TB) *JobRepository {
 	tb.Helper()
 	cclog.Init("warn", true)
-	dbfile := "testdata/job.db"
-	err := MigrateDB(dbfile)
+
+	// Copy test DB to a temp file for test isolation
+	srcData, err := os.ReadFile("testdata/job.db")
+	noErr(tb, err)
+	dbfile := filepath.Join(tb.TempDir(), "job.db")
+	err = os.WriteFile(dbfile, srcData, 0o644)
+	noErr(tb, err)
+
+	// Reset singletons so Connect uses the new temp DB
+	err = ResetConnection()
+	noErr(tb, err)
+	tb.Cleanup(func() {
+		ResetConnection()
+	})
+
+	err = MigrateDB(dbfile)
 	noErr(tb, err)
 	Connect(dbfile)
 	return GetJobRepository()
diff --git a/internal/repository/stats_test.go b/internal/repository/stats_test.go
index a8dfc818..a6c2da17 100644
--- a/internal/repository/stats_test.go
+++ b/internal/repository/stats_test.go
@@ -25,17 +25,11 @@ func TestBuildJobStatsQuery(t *testing.T) {
 func TestJobStats(t *testing.T) {
 	r := setup(t)
 
-	// First, count the actual jobs in the database (excluding test jobs)
 	var expectedCount int
-	err := r.DB.QueryRow(`SELECT COUNT(*) FROM job WHERE cluster != 'testcluster'`).Scan(&expectedCount)
+	err := r.DB.QueryRow(`SELECT COUNT(*) FROM job`).Scan(&expectedCount)
 	noErr(t, err)
 
-	filter := &model.JobFilter{}
-	// Exclude test jobs created by other tests
-	testCluster := "testcluster"
-	filter.Cluster = &model.StringInput{Neq: &testCluster}
-
-	stats, err := r.JobsStats(getContext(t), []*model.JobFilter{filter})
+	stats, err := r.JobsStats(getContext(t), []*model.JobFilter{})
 	noErr(t, err)
 
 	if stats[0].TotalJobs != expectedCount {
diff --git a/internal/repository/userConfig_test.go b/internal/repository/userConfig_test.go
index cee59304..17ccbf78 100644
--- a/internal/repository/userConfig_test.go
+++ b/internal/repository/userConfig_test.go
@@ -31,8 +31,25 @@ func setupUserTest(t *testing.T) *UserCfgRepo {
 }`
 
 	cclog.Init("info", true)
-	dbfilepath := "testdata/job.db"
-	err := MigrateDB(dbfilepath)
+
+	// Copy test DB to a temp file for test isolation
+	srcData, err := os.ReadFile("testdata/job.db")
+	if err != nil {
+		t.Fatal(err)
+	}
+	dbfilepath := filepath.Join(t.TempDir(), "job.db")
+	if err := os.WriteFile(dbfilepath, srcData, 0o644); err != nil {
+		t.Fatal(err)
+	}
+
+	if err := ResetConnection(); err != nil {
+		t.Fatal(err)
+	}
+	t.Cleanup(func() {
+		ResetConnection()
+	})
+
+	err = MigrateDB(dbfilepath)
 	if err != nil {
 		t.Fatal(err)
 	}